From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48906)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W35mj-0006EH-Qq
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 10:20:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W35mb-0000eF-5P
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 10:20:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39290)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W35ma-0000e9-St
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 10:20:01 -0500
Message-ID: <52D5558D.2010208@redhat.com>
Date: Tue, 14 Jan 2014 16:19:41 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1389632394-10130-1-git-send-email-pbonzini@redhat.com>
	<1389632394-10130-7-git-send-email-pbonzini@redhat.com>
	<52D4658E.10203@twiddle.net>
	<20140114030658.GB9212@T430.nay.redhat.com>
	<52D54DFE.9090605@twiddle.net>
In-Reply-To: <52D54DFE.9090605@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, Fam Zheng <famz@redhat.com>, mjt@tls.msk.ru, qemu-devel@nongnu.org, alex@alex.org.uk, mrezanin@redhat.com, vilanova@ac.upc.edu

Il 14/01/2014 15:47, Richard Henderson ha scritto:
>>>> +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
>>> >>
>>> >> I really really don't like random numbers that make for non-repeatable builds.
>>> >>  It's a quality-assurance nightmare.
>> > 
>> > Can you elaborate this, please?
> Build systems like we use at Red Hat want to be able to produce bit-for-bit
> identical binaries when given the exact same input.  Using random numbers
> during the build process prevents that.

I totally agree, but AIUI people wanted the symbol to be something that
you couldn't know in advance (e.g. when compiling an out-of-tree
module).  For some definition of "couldn't" and "in advance".

I think we should simply drop the requirement to check a symbol in the
modules.

Paolo

>>> >> and perhaps a file containing that hash created by scripts/make-release.
>> > 
>> > What if the source code is not in a git tree, for example a tarball?
> You just quoted my answer to that.