From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W37yh-000626-V9 for qemu-devel@nongnu.org; Tue, 14 Jan 2014 12:40:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W37ya-0003bH-35 for qemu-devel@nongnu.org; Tue, 14 Jan 2014 12:40:39 -0500 Message-ID: <52D57673.7020100@weilnetz.de> Date: Tue, 14 Jan 2014 18:40:03 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1389679228-15870-1-git-send-email-sw@weilnetz.de> <52D57343.8000205@msgid.tls.msk.ru> In-Reply-To: <52D57343.8000205@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Exclude non portable function for MinGW List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Juan Quintela Am 14.01.2014 18:26, schrieb Michael Tokarev: > 14.01.2014 10:00, Stefan Weil wrote: >> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are >> unavailable for MinGW. As the function is unused for MinGW, it can simply >> be excluded from compilation. > I applied it to -trivial. But maybe it's better to just move whole thing to kvm-all.c where > it is actually used? > > Thanks, > > /mjt That's a good suggestion. Juan, a comment in include/exec/ram_addr.h says that those functions will be removed soon. Would you suggest moving them to kvm-all.c now, or would you prefer the conditional compilation for MinGW which I introduced with my patch? Regards, Stefan