From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38Bt-0002GE-Up for qemu-devel@nongnu.org; Tue, 14 Jan 2014 12:54:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W38Bn-0007yG-VL for qemu-devel@nongnu.org; Tue, 14 Jan 2014 12:54:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W38Bn-0007y6-Lm for qemu-devel@nongnu.org; Tue, 14 Jan 2014 12:54:11 -0500 Message-ID: <52D579BE.3080209@redhat.com> Date: Tue, 14 Jan 2014 10:54:06 -0700 From: Eric Blake MIME-Version: 1.0 References: <1389719733-7689-1-git-send-email-william@gandi.net> In-Reply-To: <1389719733-7689-1-git-send-email-william@gandi.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kDtRh33lhuRvM9LSEvvLbgKGGRdPHev60" Subject: Re: [Qemu-devel] [PATCH] tap: add the possibility to specify a tap prefix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: William Dauchy , qemu-devel@nongnu.org Cc: Mark McLoughlin , Jason Wang , Paolo Bonzini , Laszlo Ersek , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kDtRh33lhuRvM9LSEvvLbgKGGRdPHev60 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/14/2014 10:15 AM, William Dauchy wrote: > this will permit to specify an interface prefix to the tap instead of t= he > default one ("tap") > this functionnality is useful when you need an easy way to find the s/functionnality/functionality/ > interfaces attached to a given virtual machine >=20 > +++ b/qapi-schema.json > @@ -3028,7 +3028,8 @@ > { 'type': 'NetdevBridgeOptions', > 'data': { > '*br': 'str', > - '*helper': 'str' } } > + '*helper': 'str', > + '*prefix': 'str'} } Need to document the new field, including when it was added. Something like: # @NetdevBridgeOptions # # Connect a host TAP network interface to a host bridge device. # # @br: #optional bridge name # # @helper: #optional command to execute to configure bridge # # @prefix: #optional prefix to use in naming the bridge, default # "tap" (since 2.0) # # Since 1.2 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kDtRh33lhuRvM9LSEvvLbgKGGRdPHev60 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS1Xm+AAoJEKeha0olJ0NqyZkIAJMw1vIUyMOqM/aSdvsP4FbS dOwLagjfv5Qlztb7B7Koag9dHdBiABHLZeI54wjLQuixwR3gJM6rCVdP9HOjca1w 9Nmb2u7PqdKbFofyJi+WYIiURcwSBabcPKs2TOZjg/jKhXFRU6CM3+ZlfREk++Tc Z0CWVUO0M35hZCOZ+YVvKyfO6aJsRjLMFwUHZQ0Z4NiSvPsdehI1H3K2pXcislN2 J6mO/MWAT1+XuuopcFvC9ThQm+SedBM4x4JuNr2pBbei1gjW5JK9rU+42CczDfes jS1ufbkTgrh6HJSVI0mNDmkvh4MtLsyBcpnOYPabpOz6EID3eGaXB4xd8Xnj3+Q= =gzn8 -----END PGP SIGNATURE----- --kDtRh33lhuRvM9LSEvvLbgKGGRdPHev60--