From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3AWK-00066P-Pg for qemu-devel@nongnu.org; Tue, 14 Jan 2014 15:23:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3AWF-00045x-TF for qemu-devel@nongnu.org; Tue, 14 Jan 2014 15:23:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3AWF-00045r-Jb for qemu-devel@nongnu.org; Tue, 14 Jan 2014 15:23:27 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EKNPV0001846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 15:23:26 -0500 Message-ID: <52D5903D.8070601@redhat.com> Date: Tue, 14 Jan 2014 12:30:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <2fb3ea05d2e1ee06d578a0f2c53f56df1661401c.1389726691.git.jcody@redhat.com> In-Reply-To: <2fb3ea05d2e1ee06d578a0f2c53f56df1661401c.1389726691.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vPlc9TalgcuClsmVIHC6uIMX8I16fwiTQ" Subject: Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vPlc9TalgcuClsmVIHC6uIMX8I16fwiTQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/14/2014 12:12 PM, Jeff Cody wrote: > Having both read-only=3Don and snapshot=3Don together does not make sen= se; > currently, the read-only argument is effectively ignored for the > temporary snapshot. To prevent confusion, disallow the usage of both > 'snapshot=3Don' and 'read-only=3Don'. >=20 > Signed-off-by: Jeff Cody > --- > blockdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Eric Blake No impact to libvirt, which (intentionally) doesn't use snapshot=3Don. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vPlc9TalgcuClsmVIHC6uIMX8I16fwiTQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS1ZA9AAoJEKeha0olJ0Nqf4oIAJ1CjMq8V2dTelmBepozMb4v TFTZhWOBcpsl3fy8O9OSuTGVPAApHX1Hl7zhgAaYCRa2qM8btVpneaMiCeLgdnrg KGEYhgLo1HW1IKHmzHSqvUd/7Y95jjgwsTe2MxHQ3aJLJkw6cQ7DLwgWBsG/VdoZ 2diecxqI0xoP/iqINW+TlQlfb8o7wOtLoSL/3W2lfNe3gf9fc0Q63MA2sUPZMggm GLrX5t1x1OeVtNLIitYSYcagcM927yG0I1tFojLDyP57xxY2C1n/pswUH9nOP+Yu HW9pBNTkShhNc1T0d3GrcbIqTVj7JqqyOJBq6CDjvg6nkRAXIkH7joVJQfUYpgU= =g/nz -----END PGP SIGNATURE----- --vPlc9TalgcuClsmVIHC6uIMX8I16fwiTQ--