From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36663)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1W3KSY-0002ru-WB
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 02:00:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1W3KSS-0008JK-0r
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 02:00:18 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:49154 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1W3KSR-0008JC-NI
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 02:00:11 -0500
Message-ID: <52D63269.3030808@kamp.de>
Date: Wed, 15 Jan 2014 08:02:01 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1389608518-4813-1-git-send-email-pl@kamp.de>
	<1389608518-4813-7-git-send-email-pl@kamp.de>
	<20140115062705.GB25475@T430.nay.redhat.com>
In-Reply-To: <20140115062705.GB25475@T430.nay.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv6 6/6] qemu-iotests: blacklist test 020 for
	NFS protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, ronniesahlberg@gmail.com, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>, owasserm@redhat.com, Federico Simoncelli <fsimonce@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On 15.01.2014 07:27, Fam Zheng wrote:
> On Mon, 01/13 11:21, Peter Lieven wrote:
>> reopening is currently not supported.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   tests/qemu-iotests/020 |    5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020
>> index a42f32f..f8a849c 100755
>> --- a/tests/qemu-iotests/020
>> +++ b/tests/qemu-iotests/020
>> @@ -46,6 +46,11 @@ _supported_fmt qcow qcow2 vmdk qed
>>   _supported_proto file
>>   _supported_os Linux
>>   
>> +# NFS does not support bdrv_reopen_prepare thus qemu-img commit fails.
>> +if [ "$IMGPROTO" = "nfs" ]; then
>> +    _notrun "image protocol $IMGPROTO does not support bdrv_commit"
>> +fi
>> +
> Doesn't "_supported_proto file" above already skip this case?
>
> Fam
You are right, the proto should be generic and just NFS should be blacklisted.

Peter