From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3PE6-0001nI-9e
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:05:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3PE0-000708-Bd
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:05:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3PDz-000703-Se
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:05:36 -0500
Message-ID: <52D6797A.1090705@redhat.com>
Date: Wed, 15 Jan 2014 13:05:14 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1389775713-996-1-git-send-email-famz@redhat.com>
	<1389775713-996-7-git-send-email-famz@redhat.com>
	<CAFEAcA_-2UdnUxhrge8s3qQSQMBZEYc3R3TGGZ6KANy+WSsu5w@mail.gmail.com>
	<52D6775B.9000704@redhat.com>
	<CAFEAcA9O0UTOsG5-K1PtjcBxqL_Sic76h_W4bvF__CW3TA_s2w@mail.gmail.com>
In-Reply-To: <CAFEAcA9O0UTOsG5-K1PtjcBxqL_Sic76h_W4bvF__CW3TA_s2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>, Alex Bligh <alex@alex.org.uk>, Miroslav Rezanina <mrezanin@redhat.com>, =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= <vilanova@ac.upc.edu>, Richard Henderson <rth@twiddle.net>

Il 15/01/2014 13:03, Peter Maydell ha scritto:
>>>>> >>> > This patch adds loading, stamp checking and initialization of modules.
>>>>> >>> > +echo "CONFIG_STAMP=`(echo $qemu_version; echo $pkgversion; cat $0) | sha256sum - | cut -f1 -d\ `" >> $config_host_mak
>>> >> This fails to configure under MacOSX, I'm afraid -- there is
>>> >> no sha256sum there.
>> >
>> > Is sha1sum there?  If yes, let's use it.
> Nope. There is shasum (because perl provides it) and md5
> (not md5sum).

Then we need a test that tries both sha1sum and shasum.

Paolo