From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3Pf6-0004vk-0H for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:33:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3Pey-00006n-48 for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:33:35 -0500 Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:37625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3Pex-00006i-Vs for qemu-devel@nongnu.org; Wed, 15 Jan 2014 07:33:28 -0500 Received: by mail-qc0-f172.google.com with SMTP id c9so875370qcz.31 for ; Wed, 15 Jan 2014 04:33:27 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52D68012.8090603@redhat.com> Date: Wed, 15 Jan 2014 13:33:22 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131217085540.GA7891@mail.duskware.de> <52B02428.20306@redhat.com> In-Reply-To: <52B02428.20306@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Martin Husemann Il 17/12/2013 11:15, Paolo Bonzini ha scritto: > Il 17/12/2013 09:55, Martin Husemann ha scritto: >> On NetBSD int8_t and friends are preprocessor macros expanding to __int8_t >> (which is a typedef provided by machine dependent headers). >> >> include/exec/softmmu_template.h tries to safe 3 lines of code by using >> preprosseor concatenation, which only will work if int8_t is not a define, >> or defined to int8_t. >> >> The attached patch fixes this. > > Hi Martin, the patch looks good, but please resend it according to the > rules in http://wiki.qemu.org/Contribute/SubmitAPatch - thanks! Ping? Paolo