From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34390)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W3Xyy-00070I-Mz
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 16:26:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W3Xys-0003U5-SI
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 16:26:40 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D6FD06.8060404@twiddle.net>
Date: Wed, 15 Jan 2014 13:26:30 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389795045-5504-1-git-send-email-tommusta@gmail.com>
	<1389795045-5504-19-git-send-email-tommusta@gmail.com>
In-Reply-To: <1389795045-5504-19-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V7 PATCH 18/18] target-ppc: Scalar Non-Signalling
 Conversions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 01/15/2014 06:10 AM, Tom Musta wrote:
> This patch adds the non-signalling scalar conversion instructions:
> 
>   - VSX Scalar Convert Single Precision to Double Precision
>     Non-Signalling (xscvspdpn)
>   - VSX Scalar Convert Double Precision to Single Precision
>     Non-Signalling (xscvdpspn)
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
> V6: New.
> 
> V7: Adjusted helper signatures per Richard Henderson's review.

Reviewed-by: Richard Henderson <rth@twiddle.net>

> +DEF_HELPER_2(xscvdpspn, i64, env, i64)
>  DEF_HELPER_2(xscvspdp, void, env, i32)
> +DEF_HELPER_2(xscvspdpn, i64, env, i64)

Something else for future cleanup, along with changing any other vsx scalar
operation according to this by-value sort of signature is to add proper helper
flags.  Since these neither raise exceptions nor set fp status bits, use

DEF_HELPER_FLAGS_2(xscvdpspn, TCG_CALL_NO_RWG_SE, i64, env, i64)


r~