From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W3Y0Z-00086U-TO
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 16:28:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W3Y0U-0003sx-3p
	for qemu-devel@nongnu.org; Wed, 15 Jan 2014 16:28:19 -0500
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D6FD69.4050501@twiddle.net>
Date: Wed, 15 Jan 2014 13:28:09 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389795045-5504-1-git-send-email-tommusta@gmail.com>
	<1389795045-5504-16-git-send-email-tommusta@gmail.com>
In-Reply-To: <1389795045-5504-16-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V7 PATCH 15/18] target-ppc: Move To/From VSR
	Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 01/15/2014 06:10 AM, Tom Musta wrote:
> +MV_VSRW(mfvsrwz, ext32u_i64, trunc_i64_tl, cpu_gpr[rA(ctx->opcode)], \
> +        cpu_vsrh(xS(ctx->opcode)))
> +MV_VSRW(mtvsrwa, extu_tl_i64, ext32s_i64, cpu_vsrh(xT(ctx->opcode)), \
> +        cpu_gpr[rA(ctx->opcode)])
> +MV_VSRW(mtvsrwz, extu_tl_i64, ext32u_i64, cpu_vsrh(xT(ctx->opcode)), \
> +        cpu_gpr[rA(ctx->opcode)])
> +

I see I responded too late this morning.  And it is true that the optimizer
will clean up what you have here.  So...

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~