From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44094)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1W3j05-0006G9-3D
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:12:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1W3izz-0004bO-4C
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:12:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:63824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1W3izy-0004bJ-SL
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:12:27 -0500
Message-ID: <52D7A2FC.3020603@redhat.com>
Date: Thu, 16 Jan 2014 11:14:36 +0200
From: Gal Hammer <ghammer@redhat.com>
MIME-Version: 1.0
References: <1387376119-11654-1-git-send-email-ghammer@redhat.com>
	<20140107072553.GB18443@grmbl.mre>
In-Reply-To: <20140107072553.GB18443@grmbl.mre>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V5] char: restore read callback on a
 reattached (hotplug) chardev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

Hi,

Anyone?

Thanks,

     Gal.

On 07/01/2014 09:25, Amit Shah wrote:
> On (Wed) 18 Dec 2013 [16:15:19], Gal Hammer wrote:
>> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
>> set the chr handlers to NULL. However when the device is plugged back,
>> its read callback is not restored so data can't be transferred from the
>> host to the guest (e.g. via the virtio-serial port).
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1027181
>>
>> Signed-off-by: Gal Hammer <ghammer@redhat.com>
>>
>> ---
>>   qemu-char.c | 21 +++++++++++++++++----
>>   1 file changed, 17 insertions(+), 4 deletions(-)
>>
>> V5: - remove_fd_in_watch in fd_chr_update_read_handler as well.
>>      - fix pty backend.
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Gerd, could you take a look as well?
>
> 		Amit
>