From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3jDO-0003K9-IZ for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:26:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3jDF-0008E6-LB for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:26:18 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:49471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3jDE-00087y-QZ for qemu-devel@nongnu.org; Thu, 16 Jan 2014 04:26:09 -0500 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 Jan 2014 19:26:05 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 6058F2BB0052 for ; Thu, 16 Jan 2014 20:26:03 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0G96wB19830716 for ; Thu, 16 Jan 2014 20:06:58 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0G9Q2Vp023063 for ; Thu, 16 Jan 2014 20:26:02 +1100 Message-ID: <52D7A5A8.4020606@linux.vnet.ibm.com> Date: Thu, 16 Jan 2014 17:26:00 +0800 From: Lei Li MIME-Version: 1.0 References: <1389172376-30636-1-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1389172376-30636-1-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH resend 0/6 RFC] Provide common methods for exchange FD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Paolo Bonzini , mohan@in.ibm.com Any comments? On 01/08/2014 05:12 PM, Lei Li wrote: > This patch series tries to refactor the functions used for > exchange of FD in current code, provide common methods > for it. > > The series is based on the localhost migration with side channel > for ram series as it was already a good shape. But if you want > to merge this first, I'll get rid of the migration part. > > I just tested page flipping migration, and tap/bridge-helper a > bit, but have some environment problem on proxy fs driver. So > it'd be appreciated if someone could help on verifying whether > it has impact on it. :) > > Please let me know if there is anything needs to be improved. > > Thanks. > > > Lei Li (6): > fd-exchange: provide common methods for exchange of fd > qemu-bridge-helper: replace send_fd with qemu_send_with_fd > net/tap: replace recv_fd with qemu_recv_with_fd > virtfs-proxy-helper: replace send_fd with qemu_send_with_fd > virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd > migration-local: replace send_pipefd with qemu_send_with_fd > > Makefile | 2 +- > fsdev/virtfs-proxy-helper.c | 51 ++++------------------- > hw/9pfs/virtio-9p-proxy.c | 60 +------------------------- > hw/9pfs/virtio-9p-proxy.h | 5 -- > include/qemu/fd-exchange.h | 25 +++++++++++ > migration-local.c | 52 +---------------------- > net/tap.c | 40 +---------------- > qemu-bridge-helper.c | 31 +------------ > util/Makefile.objs | 1 + > util/qemu-fd-exchange.c | 97 +++++++++++++++++++++++++++++++++++++++++++ > 10 files changed, 144 insertions(+), 220 deletions(-) > create mode 100644 include/qemu/fd-exchange.h > create mode 100644 util/qemu-fd-exchange.c > > -- Lei