From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3jzM-00087C-4W
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 05:15:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W3jzG-0005qK-3s
	for qemu-devel@nongnu.org; Thu, 16 Jan 2014 05:15:52 -0500
Message-ID: <52D7B14B.90104@redhat.com>
Date: Thu, 16 Jan 2014 11:15:39 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1389806638-3114-1-git-send-email-peter.maydell@linaro.org>
	<52D7065F.9020203@redhat.com>
	<CAFEAcA_6T_rB5A1Z2wtK5YHPw1CSVeG+p2uQsxX5F-+4BFjBzg@mail.gmail.com>
	<52D79A98.7050400@redhat.com>
	<CAFEAcA_5H90XWvyMZU_aDqTOXXWSXoYdxf=1Osb-015PQX-sbA@mail.gmail.com>
In-Reply-To: <CAFEAcA_5H90XWvyMZU_aDqTOXXWSXoYdxf=1Osb-015PQX-sbA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer
	callback interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-stable <qemu-stable@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Patch Tracking <patches@linaro.org>

Il 16/01/2014 10:55, Peter Maydell ha scritto:
> On 16 January 2014 08:38, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 15/01/2014 23:15, Peter Maydell ha scritto:
>>>
>>>>> +    curl_multi_socket_action(s->multi, CURL_SOCKET_TIMEOUT, 0, &running);
>>> The libcurl docs say "This function was added in libcurl 7.15.4, and
>>>  is deemed stable since 7.16.0. " So if we want to keep supporting
>>> pre-7.16 libcurl then we need to retain the multi_socket_all codepath.
>>>
>>> On the other hand 7.16 was released in October 2006. What's
>>> the oldest version we actually care about?
>>
>> I say 7.16 :)
> 
> What dos RHEL5 ship? That's usually our benchmark for
> "oldest thing we need to support". Ubuntu 10.04 LTS (lucid)
> and Debian oldstable (squeeze) both ship something more
> recent than 7.16, so we're OK there.
> 
> We should probably update the configure test to check for
> curl_multi_socket_action() rather than curl_multi_setopt().

It ships 7.15.5.  But curl_multi_socket_action is used only if there is
a timeouts, and curl_multi_timeout_do will never be called before
7.16.0.  Your patch calls aio_timer_init unconditionally, but the timer
will never be activated with timer_mod (which I think is a fine thing to
do).

Paolo