From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3pGU-0000rF-Gr for qemu-devel@nongnu.org; Thu, 16 Jan 2014 10:54:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3pGL-0006P3-Ir for qemu-devel@nongnu.org; Thu, 16 Jan 2014 10:53:54 -0500 Received: from e24smtp04.br.ibm.com ([32.104.18.25]:46838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3pGL-0006Op-6D for qemu-devel@nongnu.org; Thu, 16 Jan 2014 10:53:45 -0500 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 16 Jan 2014 13:53:43 -0200 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 1668D1DC0063 for ; Thu, 16 Jan 2014 10:53:41 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0GFr8P352035620 for ; Thu, 16 Jan 2014 13:53:08 -0200 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0GFreKf016882 for ; Thu, 16 Jan 2014 13:53:40 -0200 Message-ID: <52D80084.70500@linux.vnet.ibm.com> Date: Thu, 16 Jan 2014 13:53:40 -0200 From: Eduardo Otubo MIME-Version: 1.0 References: <20140115193744.10562.46110.stgit@localhost> <20140115193851.10562.6284.stgit@localhost> In-Reply-To: <20140115193851.10562.6284.stgit@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] seccomp: add mkdir() and fchmod() to the whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Moore Cc: Corey Bryant , qemu-devel@nongnu.org I have tested and reviewed both patches. And if nothing more comes up, I'll send a pull request by tomorrow EOD. On 01/15/2014 05:38 PM, Paul Moore wrote: > The PulseAudio library attempts to do a mkdir(2) and fchmod(2) on > "/run/user//pulse" which is currently blocked by the syscall > filter; this patch adds the two missing syscalls to the whitelist. > You can reproduce this problem with the following command: > > # qemu -monitor stdio -device intel-hda -device hda-duplex > > If watched under strace the following syscalls are shown: > > mkdir("/run/user/0/pulse", 0700) > fchmod(11, 0700) [NOTE: 11 is the fd for /run/user/0/pulse] > > Reported-by: xuhan@redhat.com > Signed-off-by: Paul Moore > --- > qemu-seccomp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > index b7c1253..89f244f 100644 > --- a/qemu-seccomp.c > +++ b/qemu-seccomp.c > @@ -220,7 +220,9 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = { > { SCMP_SYS(io_cancel), 241 }, > { SCMP_SYS(io_setup), 241 }, > { SCMP_SYS(io_destroy), 241 }, > - { SCMP_SYS(arch_prctl), 240 } > + { SCMP_SYS(arch_prctl), 240 }, > + { SCMP_SYS(mkdir), 240 }, > + { SCMP_SYS(fchmod), 240 } ACK. -- Eduardo Otubo IBM Linux Technology Center