From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3q9g-0003P2-PT for qemu-devel@nongnu.org; Thu, 16 Jan 2014 11:51:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3q9b-0007yY-Tk for qemu-devel@nongnu.org; Thu, 16 Jan 2014 11:50:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3q9b-0007yQ-KN for qemu-devel@nongnu.org; Thu, 16 Jan 2014 11:50:51 -0500 Message-ID: <52D80DE4.6030100@redhat.com> Date: Thu, 16 Jan 2014 09:50:44 -0700 From: Eric Blake MIME-Version: 1.0 References: <1389890079-21853-1-git-send-email-imammedo@redhat.com> <1389890079-21853-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1389890079-21853-3-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BC2bM1fxt45q8pr7AT1SwKcm7pOqbgJPU" Subject: Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: sw@weilnetz.de, mjt@tls.msk.ru, lcapitulino@redhat.com, blauwirbel@gmail.com, aliguori@amazon.com, stefanha@gmail.com, pbonzini@redhat.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BC2bM1fxt45q8pr7AT1SwKcm7pOqbgJPU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2014 09:34 AM, Igor Mammedov wrote: s/ingnore/ignore/ in subject > object_property_add_child() may fail if 'id' matches > an already existing object. Which meansi an incorrect s/meansi/means/ > command line. > So instead of silently ignoring error, report it and > terminate QEMU. >=20 > Signed-off-by: Igor Mammedov > --- > vl.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) Fix those, and you can add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BC2bM1fxt45q8pr7AT1SwKcm7pOqbgJPU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS2A3kAAoJEKeha0olJ0Nq62YH+wYDm2FckU4CAxfGJKfO1Fx9 rOCkL5H43S62VTjILdv7v2ZYwmfRgKqWULeBEW0+q7LHoK+8nq7RpXBkJLfVn3VJ E5tmIe6yXfdphjwT5i2BdXKJ9/ZwnyuNFds1PG/cJBUb02RuQqtWuGHzeNVOCH0U glhVEAnvW2pUsONdomHsMzmFUI2VrjJPHSykUkvip85Ir+WN+YsO445oVaAY8J1o CavoHMVXGDhIQLQIquZ0k1iTGMbLCTY0zRX2Wio5VIZRkcf3NIEKizxkjx2G8Gl5 b+6cASLAfa8jUYc6Pu+DMnE6DIsfNDo+x8utsq+kQyXSaV0oWAeadtRgdOKvFks= =1PvP -----END PGP SIGNATURE----- --BC2bM1fxt45q8pr7AT1SwKcm7pOqbgJPU--