From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3zg3-0001MR-IP for qemu-devel@nongnu.org; Thu, 16 Jan 2014 22:01:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3zfu-00033I-Ev for qemu-devel@nongnu.org; Thu, 16 Jan 2014 22:00:59 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:50299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3zft-00032v-JZ for qemu-devel@nongnu.org; Thu, 16 Jan 2014 22:00:50 -0500 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Jan 2014 13:00:43 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 7F8A92BB0052 for ; Fri, 17 Jan 2014 14:00:41 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0H2fhca12451852 for ; Fri, 17 Jan 2014 13:41:44 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0H30dbf001910 for ; Fri, 17 Jan 2014 14:00:39 +1100 Message-ID: <52D89CD6.9000506@linux.vnet.ibm.com> Date: Fri, 17 Jan 2014 11:00:38 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1386148259-10962-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1386148259-10962-4-git-send-email-xiawenc@linux.vnet.ibm.com> <20140116125225.GE3369@dhcp-200-207.str.redhat.com> In-Reply-To: <20140116125225.GE3369@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com 于 2014/1/16 20:52, Kevin Wolf 写道: > Am 04.12.2013 um 10:10 hat Wenchao Xia geschrieben: >> This case can't run when IMGPROTO=nbd, since it needs to create some >> internal snapshot which would fail for EOF write request, even when >> TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto >> to file. >> >> _require_command() is changed to tip what util is missing, instead >> of printing a blank. >> >> Signed-off-by: Wenchao Xia > >> --- a/tests/qemu-iotests/group >> +++ b/tests/qemu-iotests/group >> @@ -64,6 +64,7 @@ >> 055 rw auto >> 056 rw auto backing >> 057 rw auto >> +058 rw auto >> 059 rw auto >> 060 rw auto >> 061 rw auto > > Please, please, please, stop doing this. > > If you see a hole in the numbering of test cases, it is because there > are yet unmerged patches that use this number. The only thing you > achieve by filling up the hole is merge conflicts. I have branches that > regularly require manual conflict resolution because people think they > are clever when they fill up holes. > > Simply add your cases to the end of the file, okay? (And up to 078 is > taken now, if someone needs to assign a new test number for his patch.) > > Kevin > 058 is the last number when I patched v1 if I didn't miss patch on list, but you are right whole in number shouldn't be filled by new patch.