From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W48kT-0004hk-Ow
	for qemu-devel@nongnu.org; Fri, 17 Jan 2014 07:42:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W48kN-0000RW-By
	for qemu-devel@nongnu.org; Fri, 17 Jan 2014 07:42:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2498)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W48kN-0000R6-4p
	for qemu-devel@nongnu.org; Fri, 17 Jan 2014 07:42:03 -0500
Message-ID: <52D92514.80600@redhat.com>
Date: Fri, 17 Jan 2014 13:41:56 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <87ppnq6h5y.fsf@blackfin.pond.sub.org>
In-Reply-To: <87ppnq6h5y.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] device_add error handling regressed in v1.5.0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Il 17/01/2014 11:23, Markus Armbruster ha scritto:
> e0a83fc2c1582dc8d4453849852ebe6c258b7c3a is the first bad commit
> commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Tue Apr 2 15:50:00 2013 +0200
> 
>     qom: do nothing on unparent of object without parent
>     
>     Otherwise, device_unparent will fail to get a canonical path of
>     the object.
>     
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>     Message-id: 1364910600-3418-1-git-send-email-pbonzini@redhat.com
>     Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 

I think Amos had a fix for this.

Paolo