From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4B05-0003Rn-6h for qemu-devel@nongnu.org; Fri, 17 Jan 2014 10:06:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4Azx-0006vG-TE for qemu-devel@nongnu.org; Fri, 17 Jan 2014 10:06:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49878 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4Azx-0006vA-Mg for qemu-devel@nongnu.org; Fri, 17 Jan 2014 10:06:17 -0500 Message-ID: <52D946E4.7030708@suse.de> Date: Fri, 17 Jan 2014 16:06:12 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1389781375-11774-1-git-send-email-kwolf@redhat.com> <1389781375-11774-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1389781375-11774-11-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 10/42] qtest: Fix the bug about disable vnc causes "make check" fail List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws Am 15.01.2014 11:22, schrieb Kevin Wolf: > From: Kewei Yu >=20 > When we disable vnc from "./configure", QEMU can't use the vnc option. > So qtest can't use the "vnc -none ", otherwise "make check" fails. > If QEMU uses "-display none", "-vnc none" is excrescent, So we just nee= d to drop it. >=20 > Signed-off-by: Kewei Yu > Reviewed-by: Paolo Bonzini > Signed-off-by: Kevin Wolf If the pull does get respun, 'Fix "make check" failing for --disable-vnc' would be better English. ;) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg