From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4IhJ-0004M8-4A for qemu-devel@nongnu.org; Fri, 17 Jan 2014 18:19:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4IhC-00056Z-P1 for qemu-devel@nongnu.org; Fri, 17 Jan 2014 18:19:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4IhC-00056V-H3 for qemu-devel@nongnu.org; Fri, 17 Jan 2014 18:19:26 -0500 Message-ID: <52D9BAE6.8030806@redhat.com> Date: Sat, 18 Jan 2014 00:21:10 +0100 From: Max Reitz MIME-Version: 1.0 References: <1389968119-24771-1-git-send-email-kwolf@redhat.com> <1389968119-24771-17-git-send-email-kwolf@redhat.com> In-Reply-To: <1389968119-24771-17-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 16/29] block: Make zero-after-EOF work with larger alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, pl@kamp.de, xiawenc@linux.vnet.ibm.com, stefanha@redhat.com On 17.01.2014 15:15, Kevin Wolf wrote: > Odd file sizes could make bdrv_aligned_preadv() shorten the request in > non-aligned ways. Fix it by rounding to the required alignment instead > of 512 bytes. > > Signed-off-by: Kevin Wolf > --- > block.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz