From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Hh9-0004M2-Tt for qemu-devel@nongnu.org; Mon, 20 Jan 2014 11:27:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5Hh3-0005Rf-Nm for qemu-devel@nongnu.org; Mon, 20 Jan 2014 11:27:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40666 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Hh3-0005Rb-HT for qemu-devel@nongnu.org; Mon, 20 Jan 2014 11:27:21 -0500 Message-ID: <52DD4E66.8040708@suse.de> Date: Mon, 20 Jan 2014 17:27:18 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1390228618-21663-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1390228618-21663-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Igor Mammedov , Bandan Das , Paolo Bonzini , Anthony Liguori , "Michael S. Tsirkin" Am 20.01.2014 15:36, schrieb Eduardo Habkost: > This enables x2apic on the following CPU models: Conroe, Penryn, > Nehalem, Westmere, Opteron_G[12345]. >=20 > Normally we try to keep the CPU model definitions as close as the real > CPUs as possible, but x2apic can be emulated by KVM without host CPU > support for x2apic, and it improves performance by reducing APIC access > overhead. x2apic emulation is available on KVM since 2009 (Linux > 2.6.32-rc1), there's no reason for not enabling x2apic by default when > running KVM. >=20 > About testing: Conroe, Penryn, Nehalem, Westemere and Opteron_G[123] > have x2apic enabled on RHEL-6 since RHEL-6.0, so the presence of x2apic > on those CPU models got lots of testing in the last few years. I want t= o > eventually enable x2apic on all other CPU models as well, but it will > require some testing to ensure it won't confuse guests. >=20 > This shouldn't affect TCG at all because features not supported by TCG > are automatically and silently disabled by QEMU when initializing the > CPU. >=20 > Signed-off-by: Eduardo Habkost > --- > v1 was sent in September 2013: > Message-Id: <1379704517-19177-1-git-send-email-ehabkost@redhat.com> > http://article.gmane.org/gmane.comp.emulators.qemu/234541 >=20 > It got an Acked-by from Gleb but it was ignored by all maintainers. Sorry, was still unread in my inbox. What changed between this version and said v1? Just moving to _1_7? I.e. should I add back Gleb's Acked-by before your Sob when applying? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg