From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5NBM-0002Ho-78 for qemu-devel@nongnu.org; Mon, 20 Jan 2014 17:19:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5NBE-000075-Cw for qemu-devel@nongnu.org; Mon, 20 Jan 2014 17:19:00 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46247 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5NBE-00006w-5t for qemu-devel@nongnu.org; Mon, 20 Jan 2014 17:18:52 -0500 Message-ID: <52DDA0C8.8090303@suse.de> Date: Mon, 20 Jan 2014 23:18:48 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1390228618-21663-1-git-send-email-ehabkost@redhat.com> <52DD4E66.8040708@suse.de> <20140120165001.GC9488@otherpad.lan.raisama.net> In-Reply-To: <20140120165001.GC9488@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Bandan Das , Anthony Liguori , Paolo Bonzini , Igor Mammedov Am 20.01.2014 17:50, schrieb Eduardo Habkost: > On Mon, Jan 20, 2014 at 05:27:18PM +0100, Andreas F=E4rber wrote: >> Am 20.01.2014 15:36, schrieb Eduardo Habkost: >>> v1 was sent in September 2013: >>> Message-Id: <1379704517-19177-1-git-send-email-ehabkost@redhat.com> >>> http://article.gmane.org/gmane.comp.emulators.qemu/234541 >>> >>> It got an Acked-by from Gleb but it was ignored by all maintainers. >> >> Sorry, was still unread in my inbox. What changed between this version >> and said v1? Just moving to _1_7? I.e. should I add back Gleb's Acked-= by >> before your Sob when applying? >=20 > Yes, the only change from v1 was on the compat code. I didn't think I > should have included Gleb's Acked-by because he didn't review the compa= t > code changes (and I could have made mistakes when rebasing), but if you > think it is appropriate, you can pull Gleb's Acked-by. I've inserted it, staging it on qom-cpu-next for now. It is a matter of ordering the *-by before your Sob rather than after it and, if changes were more than stylistic, adding a [you: ...] line. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg