From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5YB4-0005no-95 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:03:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5YAy-000777-AE for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:03:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5YAy-00076y-27 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:03:20 -0500 Message-ID: <52DE45E3.5010208@redhat.com> Date: Tue, 21 Jan 2014 11:03:15 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390228618-21663-1-git-send-email-ehabkost@redhat.com> <52DD9F77.4040904@suse.de> In-Reply-To: <52DD9F77.4040904@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Bandan Das , Anthony Liguori , Igor Mammedov Il 20/01/2014 23:13, Andreas F=E4rber ha scritto: > I don't like the argument that we can put arbitrary stuff in our model > definitions and rely on TCG not having implemented it to make it > correct. Is x2apic something that TCG can never implement for some > reason? Then that needs a better explanation. Otherwise, is there no > criteria we can add this flag for when kvm_enabled()? We already do that for other bits (e.g. XSAVE/OSXSAVE), and in fact it is the same that we do for KVM: the KVM_GET_SUPPORTED_CPUID result is used to trim the generic feature bits. Paolo