From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5YVu-00075N-Hl for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:25:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5YVn-0006MB-7l for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:24:58 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52663 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5YVn-0006M3-1N for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:24:51 -0500 Message-ID: <52DE4AEF.20109@suse.de> Date: Tue, 21 Jan 2014 11:24:47 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1390299589-5082-1-git-send-email-kraxel@redhat.com> <1390299589-5082-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1390299589-5082-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/1] hda-codec: disable streams on reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: "Vassili Karpov (malc)" Am 21.01.2014 11:19, schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- > hw/audio/hda-codec.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >=20 > diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c > index 07a43bf..986f2a9 100644 > --- a/hw/audio/hda-codec.c > +++ b/hw/audio/hda-codec.c > @@ -559,6 +559,21 @@ static int hda_audio_post_load(void *opaque, int v= ersion) > return 0; > } > =20 > +static void hda_audio_reset(DeviceState *dev) > +{ > + HDAAudioState *a =3D DO_UPCAST(HDAAudioState, hda.qdev, dev); [snip] Can you please follow up with a QOM cast macro to avoid adding more DO_UPCAST() usages? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg