From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5bez-0001Hm-2l for qemu-devel@nongnu.org; Tue, 21 Jan 2014 08:46:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5bep-0006S8-30 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 08:46:33 -0500 Message-ID: <52DE7A20.3060600@redhat.com> Date: Tue, 21 Jan 2014 06:46:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <33183CC9F5247A488A2544077AF19020815BB9E1@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020815BB9E1@SZXEMA503-MBS.china.huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9An40gpKMfnTEuseQnFbRtmgL3bsxlD5U" Subject: Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "qemu-devel@nongnu.org" , "qemu-stable@nongnu.org" , Peter Maydell , "anthony@codemonkey.ws" , "pbonzini@redhat.com" Cc: "chenliang (T)" , Luonengjun , "Huangweidong (Hardware)" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9An40gpKMfnTEuseQnFbRtmgL3bsxlD5U Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/21/2014 05:11 AM, Gonglei (Arei) wrote: > Hi, This greeting... >=20 > This is an update of my patch. > Modifications in v2: =2E..and this mention of what you changed in v2,... > * Removing excess check for g_free > * The structure of XBZRLE is divided into two halves.One is for > * src side, another is for dest side. >=20 > Signed-off-by: chenliang > --- =2E..belong here, after the --- marker. Basically, patch emails should have two portions: the long-lived portion before the --- that will be stashed into git and which will always be relevant to someone reading the patch a year from now, and the transient portion after the --- that is helpful to reviewers that have context about why you are on v2, but which makes no difference in git (a year from now, we won't care if it took 1 version or 20 versions to get to the final patch, because git will only have the final version). If you need help writing a good commit message, browsing 'git log' will give you some ideas. See also http://wiki.qemu.org/Contribute/SubmitAPat= ch --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9An40gpKMfnTEuseQnFbRtmgL3bsxlD5U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS3nogAAoJEKeha0olJ0NqGw4H/RHN7OUJvhZA6+a8uVIL1k4A wmbWYffZBta46/yZI0aiAT9qQjSBY4nPfL0MnoVOJduxbj34EwEQvpmzRvel4b86 ojgPrFpgMtzjTkBq/I3+4u3OD4v/ohLg5AdiZZdtzBPNhFpNSoH9Ay05ckTQkbOM ZvgSCtKepfWN2FFVbTQRI0wyJSZDZBz+PCLG2CrEd1ThiP3avYlcvjxoUEIKqiEE daiVwuPM+y3aJ32dKg23ijAUo1dO9hVbb3F0QsersfYwHDIbO8jKRSxaPUIrcGlZ +Qvz993BV10x80Ix1jovld312JGnjd3E2wItKckzf8d1RtloUz3uFiaaAgN49N4= =PHft -----END PGP SIGNATURE----- --9An40gpKMfnTEuseQnFbRtmgL3bsxlD5U--