From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
Martin Husemann <martin@duskware.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD
Date: Tue, 21 Jan 2014 07:38:00 -0800 [thread overview]
Message-ID: <52DE9458.20007@twiddle.net> (raw)
In-Reply-To: <CAFEAcA9p_QDnVhYFnB+WgHiyMR30XgB2y1FE8C2_0j=1U-nV+g@mail.gmail.com>
On 01/18/2014 05:59 AM, Peter Maydell wrote:
> On 18 January 2014 13:47, Martin Husemann <martin@duskware.de> wrote:
>> Do not rely on int8_t (and friends) not being preprocessor
>> symbols (or symbols expanding to themselves). On NetBSD (for example) the
>> glue(u, SDATA_TYPE) results in u__int8_t, which is undefined. There is no way
>> to stop cpp expanding inner macros, so just add the few lines explicitly and
>> get rid of the magic.
>>
>> Signed-off-by: Martin Husemann <martin@NetBSD.org>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> This was introduced in commit c8f94df593.
> Richard, do you want to take this fix via the tcg tree, or should it
> go via trivial?
Trivial is fine. Saves me the effort. ;-)
r~
next prev parent reply other threads:[~2014-01-21 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 8:55 [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch) Martin Husemann
2013-12-17 10:15 ` Paolo Bonzini
2014-01-15 12:33 ` Paolo Bonzini
2014-01-18 13:47 ` [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD Martin Husemann
2014-01-18 13:59 ` Peter Maydell
2014-01-21 15:38 ` Richard Henderson [this message]
2014-01-21 15:42 ` Andreas Färber
2014-01-21 18:11 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE9458.20007@twiddle.net \
--to=rth@twiddle.net \
--cc=martin@duskware.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).