From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5dOz-0003G1-Pz for qemu-devel@nongnu.org; Tue, 21 Jan 2014 10:38:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5dOv-0000zR-L9 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 10:38:09 -0500 Received: from mail-qa0-x236.google.com ([2607:f8b0:400d:c00::236]:44741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5dOv-0000zG-GS for qemu-devel@nongnu.org; Tue, 21 Jan 2014 10:38:05 -0500 Received: by mail-qa0-f54.google.com with SMTP id i13so6740099qae.27 for ; Tue, 21 Jan 2014 07:38:04 -0800 (PST) Sender: Richard Henderson Message-ID: <52DE9458.20007@twiddle.net> Date: Tue, 21 Jan 2014 07:38:00 -0800 From: Richard Henderson MIME-Version: 1.0 References: <20131217085540.GA7891@mail.duskware.de> <52B02428.20306@redhat.com> <52D68012.8090603@redhat.com> <20140118134723.GA20716@mail.duskware.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Martin Husemann Cc: QEMU Developers On 01/18/2014 05:59 AM, Peter Maydell wrote: > On 18 January 2014 13:47, Martin Husemann wrote: >> Do not rely on int8_t (and friends) not being preprocessor >> symbols (or symbols expanding to themselves). On NetBSD (for example) the >> glue(u, SDATA_TYPE) results in u__int8_t, which is undefined. There is no way >> to stop cpp expanding inner macros, so just add the few lines explicitly and >> get rid of the magic. >> >> Signed-off-by: Martin Husemann > > Reviewed-by: Peter Maydell > > This was introduced in commit c8f94df593. > Richard, do you want to take this fix via the tcg tree, or should it > go via trivial? Trivial is fine. Saves me the effort. ;-) r~