From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5e15-00056w-1m for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:17:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5e0z-0005Ds-52 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:17:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5e0y-0005DV-RX for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:17:25 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0LGHM5O001921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Jan 2014 11:17:22 -0500 Message-ID: <52DE9D8F.8020309@redhat.com> Date: Tue, 21 Jan 2014 09:17:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <0715fccd414384a7c177ff93e976a40b2e938650.1390320839.git.jcody@redhat.com> In-Reply-To: <0715fccd414384a7c177ff93e976a40b2e938650.1390320839.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CmiJUFaRH3nxDhtATMORHu4pEAvpL4K5I" Subject: Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CmiJUFaRH3nxDhtATMORHu4pEAvpL4K5I Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/21/2014 09:14 AM, Jeff Cody wrote: > Important note: this patch should only be applied after patch > "block: do not allow read-only=3Don and snapshot=3Don to be used toget= her" >=20 > Now that 'read-only=3Don' and 'snapshot=3Don' are not allowed together,= > forcing open_flags to have BDRV_O_RDWR set is redundant code, and can b= e > removed. This is because unless read-only=3Don is specified, the image= > will always be opened with BDRV_O_RDWR set. >=20 > Signed-off-by: Jeff Cody > --- > block.c | 7 ------- > 1 file changed, 7 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CmiJUFaRH3nxDhtATMORHu4pEAvpL4K5I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS3p2PAAoJEKeha0olJ0NqfsQH/iHlhpsYQr3n5bBF1z8PjKn+ N/gCMK1ZaYDY/tp0PDrPnlBbyZGV+Q5vkd95XmHJJS2Usr0Gn1WLedurKclYxbvY tW8fGRyXKumdQwtVUfg8otDnoHCSJxi9tjR906j02dWuxVA+YyjjBnmOct8BAscv pN3TSAQKjoD687WNgMQwiLrBREmcuvdQomSatrD5Gzr/sgCfaTPG4XJqviJPiEtz /xPzeH9d6LbLZJTlre8DK+ZohlreLjpfPCmA1Bu0OK5K44mpEInytYJqyWMwafYB SB1K9rqnLRn84bmJTnXZQ2gcfsIE5wOmbk/0UoL/GUxwTPdq7hjXgRZZxiCg9zw= =BipN -----END PGP SIGNATURE----- --CmiJUFaRH3nxDhtATMORHu4pEAvpL4K5I--