From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5eKF-00013L-He for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:37:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5eKA-0004Wj-Ka for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:37:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5eKA-0004WZ-D5 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:37:14 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0LGbCkU011881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Jan 2014 11:37:13 -0500 Message-ID: <52DEA237.4000402@redhat.com> Date: Tue, 21 Jan 2014 09:37:11 -0700 From: Eric Blake MIME-Version: 1.0 References: <3dddeafeb7301de9cb3649cff023de74d28d1bab.1390321064.git.jcody@redhat.com> In-Reply-To: <3dddeafeb7301de9cb3649cff023de74d28d1bab.1390321064.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2cPHDamvGoAmvMI2fk9XVNtswRmgi0cET" Subject: Re: [Qemu-devel] [PATCH v2 3/3] block: update block commit documentation regarding image truncation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2cPHDamvGoAmvMI2fk9XVNtswRmgi0cET Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/21/2014 09:31 AM, Jeff Cody wrote: > This updates the documentation for commiting snapshot images. > Specifically, this highlights what happens when the base image > is either smaller or larger than the snapshot image being committed. >=20 > In the case of the base image being smaller, it is resized to the > larger size of the snapshot image. In the case of the base image > being larger, it is not resized automatically, but once the commit > has completed it is safe for the user to truncate the base image. >=20 > Signed-off-by: Jeff Cody > --- > +++ b/qapi-schema.json > @@ -1973,6 +1973,13 @@ > # user needs to complete the job with the block-job= -complete > # command after getting the ready event. (Since 2.0= ) > # > +# If the base image is smaller than top, then the b= ase image > +# will be resized to be the same size as top. If t= op is > +# smaller than the base image, the base will not b= e Spurious double space. > +SQMP > +block-commit > +------------ > + > + > + If the base image is smaller than top, then the base image > + will be resized to be the same size as top. If top is > + smaller than the base image, the base will not be and again. But as that is minor, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2cPHDamvGoAmvMI2fk9XVNtswRmgi0cET Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS3qI3AAoJEKeha0olJ0NqtPsIAKxiZmPupTxq2tg1zj+bazI/ 5KPk9xIHxMUYXLmiVF5T8378EESa7Dtg1oZGDBMlBlRTmBeDSADrIodD8SHftRaD yqEL453Y5lvLI/5k0LaKKpsJo5GX1PeKRJPXDEAAcQU+MtuieOHGijFyTGttciKB OBFECVzBZiY3cbydMkXp64ru57DF0lsiXal4Ngk9Nmv+wnUq3YtjvkWZ1uv8CnZG MC2QsCvWJo7EgMvMlAwCmZdKB5PoUfdz/IAS/JKa/GowI6VQU5j96ZBznITn2ybo IkZtM+OEoSOqg1hdU6Dyl3YDfVPYB+R5T4oHrQi6//9expp1kxGbPOdKb444EIo= =r2zf -----END PGP SIGNATURE----- --2cPHDamvGoAmvMI2fk9XVNtswRmgi0cET--