From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5eOF-0005C2-3X for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:41:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5eOA-00065n-8j for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:41:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5eO9-00065d-Vj for qemu-devel@nongnu.org; Tue, 21 Jan 2014 11:41:22 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0LGfK46014180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 Jan 2014 11:41:21 -0500 Message-ID: <52DEA32F.9070909@redhat.com> Date: Tue, 21 Jan 2014 09:41:19 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vDROMjvdJdA8i7m41QTQ25g8M0QWpqSfe" Subject: Re: [Qemu-devel] [PATCH v2 1/3] block: resize backing file image during offline commit, if necessary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vDROMjvdJdA8i7m41QTQ25g8M0QWpqSfe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/21/2014 09:31 AM, Jeff Cody wrote: > Currently, if an image file is logically larger than its backing file, > commiting it via 'qemu-img commit' will fail. s/commiting/committing/ >=20 > For instance, if we have a base image with a virtual size 10G, and a > snapshot image of size 20G, then committing the snapshot offline with > 'qemu-img commit' will likely fail. >=20 > This will automatically attempt to resize the base image, if the > snapshot image to be committed is larger. >=20 > Signed-off-by: Jeff Cody > --- > block.c | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) >=20 The commit message change is trivial, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vDROMjvdJdA8i7m41QTQ25g8M0QWpqSfe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS3qMvAAoJEKeha0olJ0NqD08H+gLhKp6sCmgFi2qG/bQef7yL lSrJEAwSkyXEsZw6PEGYezQ/0ya5Y1j0GY7ooAkyb5Sng3gak0Stg+lHxdXSUrP4 ck9IqsPTLqdilvRdCgMW/kEoryLIHCaGCpeBhQwo88P6q6C5/ZQwNYjuoHxzsnAv 6EJTxcTD2MghxUs2h8h2Ea55gSarZbFXEUuzzcWiXErzfCeQfah0Bu4XOFwlkQtL xpy46wLU/TgWZtZJjtNvPWbUVlbjY9ll1cjcR5BE1CvONca3liLDv3TxrqHwDXj4 b521Jx9KmQ9HussrqmZCbnqBGzPr/QYm6OfLXtXQFwpspnnN0KPs8VbGnwZoYDE= =MzFf -----END PGP SIGNATURE----- --vDROMjvdJdA8i7m41QTQ25g8M0QWpqSfe--