From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6list@gmail.com>) id 1W5pum-00037u-RW
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 23:59:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xbing6list@gmail.com>) id 1W5pug-0001Sz-Tu
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 23:59:48 -0500
Received: from mail-pd0-x235.google.com ([2607:f8b0:400e:c02::235]:59028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6list@gmail.com>) id 1W5pug-0001So-Is
	for qemu-devel@nongnu.org; Tue, 21 Jan 2014 23:59:42 -0500
Received: by mail-pd0-f181.google.com with SMTP id y10so5573693pdj.12
	for <qemu-devel@nongnu.org>; Tue, 21 Jan 2014 20:59:41 -0800 (PST)
Message-ID: <52DF502F.8090903@gmail.com>
Date: Wed, 22 Jan 2014 12:59:27 +0800
From: Xbing Wang <xbing6list@gmail.com>
MIME-Version: 1.0
References: <1389984257-6822-1-git-send-email-peter.maydell@linaro.org>	<1389984257-6822-7-git-send-email-peter.maydell@linaro.org>	<52DECC87.9010503@twiddle.net>
	<CAFEAcA8_Ey-10PzFE+9qLJDFWb4WtXDXoHdu9mztr8_jr1i4pA@mail.gmail.com>
In-Reply-To: <CAFEAcA8_Ey-10PzFE+9qLJDFWb4WtXDXoHdu9mztr8_jr1i4pA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/8] target-arm: A64: Add integer ops from
 SIMD 3-same group
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

Making them static makes this function NOT thread-safe (and they're 
hidden in thousands of lines of codes), there will be boys who want the 
whole file translate-a64.c to be thread-safe. What do you think?

Thanks.
- xbing

On 01/22/2014 03:53 AM, Peter Maydell wrote:
> On 21 January 2014 19:37, Richard Henderson <rth@twiddle.net> wrote:
>> On 01/17/2014 10:44 AM, Peter Maydell wrote:
>>> +                NeonGenFn *ceqtstfns[3][2] = {
>> You want all of these arrays to be static and const:
>>
>>    static NeonGenFn * const ceqtstfns[3][2] = ...
> I confess I couldn't figure out the right place to
> put the 'const' to placate the compiler :-)
>
> thanks
> -- PMM
>
>