From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rudy.zhangmin@huawei.com>) id 1W5rh6-00017J-He
	for qemu-devel@nongnu.org; Wed, 22 Jan 2014 01:53:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rudy.zhangmin@huawei.com>) id 1W5rh2-0008GR-6q
	for qemu-devel@nongnu.org; Wed, 22 Jan 2014 01:53:48 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:28492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rudy.zhangmin@huawei.com>) id 1W5rh1-0008Fy-Hb
	for qemu-devel@nongnu.org; Wed, 22 Jan 2014 01:53:44 -0500
Message-ID: <52DF6AE3.1030207@huawei.com>
Date: Wed, 22 Jan 2014 14:53:23 +0800
From: Zhang Min <rudy.zhangmin@huawei.com>
MIME-Version: 1.0
References: <93A91DC620F1514FB39E878E5131C8CF0E360A4F@nkgeml511-mbx.china.huawei.com>
	<20140122034143.GA24497@T430.redhat.com>
In-Reply-To: <20140122034143.GA24497@T430.redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] drive-mirror: fix memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, "Chentao (Boby)" <boby.chen@huawei.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Qinling <mail.qinling@huawei.com>, "Wubin (H)" <wu.wubin@huawei.com>, "Wangting (Kathy)" <kathy.wangting@huawei.com>

Hi,Fam
I am very sorry for this patch,because I use Outlook to send this email.
Later on, I will submit the patch by git send-email again.

On 2014/1/22 11:41, Fam Zheng wrote:
> Hi,
> 
> The patch itself looks good to me, but it has too many extra empty lines
> interleaved. Please try to use "git send-email" to submit your patches, for
> more information, follow the instructions as in:
> 
> http://wiki.qemu.org/Contribute/SubmitAPatch
> 
> On Tue, 01/21 11:43, Chentao (Boby) wrote:
>> In the function mirror_iteration() -> qemu_iovec_init(), it alloc memory for op->qiov.iov, when the write request call back,
> 
> s/alloc/allocates/
> s/call back/calls back/
> 
>>
>>
>>
>> but in the function mirror_iteration_done(), it only free the op, not free the op->qiov.iov, so this cause memory leak.
> 
> s/free/frees/
> s/cause/causes/
> 
>>
>>
>>
>> Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com<mailto:rudy.zhangmin@huawei.com>>
> 
> Unnecessary <mailto:> notation here.
> 
>>
>> ---
>>
>> block/mirror.c |    1 +
>>
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>>
>> diff --git a/block/mirror.c b/block/mirror.c index 2932bab..9840840 100644
>>
>> --- a/block/mirror.c
>>
>> +++ b/block/mirror.c
>>
>> @@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret)
>>
>>          bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);
>>
>>      }
>>
>>
>>
>> +    g_free(op->qiov.iov);
>>
>>      g_slice_free(MirrorOp, op);
>>
>>      qemu_coroutine_enter(s->common.co, NULL);  }
>>
>> --
>>
>>
> 
> 

-- 

Zhang Min