From: Zhang Min <rudy.zhangmin@huawei.com>
To: qemu-devel <qemu-devel@nongnu.org>, Fam Zheng <famz@redhat.com>
Cc: rudy.zhangmin@huawei.com, Qinling <mail.qinling@huawei.com>,
"Chentao (Boby)" <boby.chen@huawei.com>,
"Wubin (H)" <wu.wubin@huawei.com>,
"Wangting (Kathy)" <kathy.wangting@huawei.com>
Subject: [Qemu-devel] [PATCH] drive-mirror:fix memory leak
Date: Wed, 22 Jan 2014 15:56:08 +0800 [thread overview]
Message-ID: <52DF7998.1000601@huawei.com> (raw)
In the function mirror_iteration() -> qemu_iovec_init(),
it allocates memory for op->qiov.iov, when the write request calls back,
but in the function mirror_iteration_done(), it only frees the op,
not free the op->qiov.iov, so this causes memory leak.
Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com>
---
block/mirror.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 2932bab..9840840 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret)
bitmap_set(s->cow_bitmap, chunk_num, nb_chunks);
}
+ g_free(op->qiov.iov);
g_slice_free(MirrorOp, op);
qemu_coroutine_enter(s->common.co, NULL);
}
--
1.7.3.1.msysgit.0
next reply other threads:[~2014-01-22 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 7:56 Zhang Min [this message]
2014-01-22 8:27 ` [Qemu-devel] [PATCH] drive-mirror:fix memory leak Fam Zheng
2014-01-22 9:42 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2014-01-21 11:43 [Qemu-devel] [PATCH] drive-mirror: fix " Chentao (Boby)
2014-01-22 3:41 ` Fam Zheng
2014-01-22 6:53 ` Zhang Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DF7998.1000601@huawei.com \
--to=rudy.zhangmin@huawei.com \
--cc=boby.chen@huawei.com \
--cc=famz@redhat.com \
--cc=kathy.wangting@huawei.com \
--cc=mail.qinling@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).