From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5yJE-00032N-8C for qemu-devel@nongnu.org; Wed, 22 Jan 2014 08:57:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5yJ8-0001dA-U1 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 08:57:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5yJ8-0001cy-KG for qemu-devel@nongnu.org; Wed, 22 Jan 2014 08:57:30 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0MD8YwE003680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Jan 2014 08:08:34 -0500 Message-ID: <52DFC2D1.9060901@redhat.com> Date: Wed, 22 Jan 2014 06:08:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <1390361416-24234-1-git-send-email-famz@redhat.com> <20140122093553.GB10065@dhcp-200-207.str.redhat.com> In-Reply-To: <20140122093553.GB10065@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nbUXus2wtnHQ3kaFKEdC9JR4CjGhltoHh" Subject: Re: [Qemu-devel] [PATCH] qapi: Add "backing" and "file" to BlockStats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nbUXus2wtnHQ3kaFKEdC9JR4CjGhltoHh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/22/2014 02:35 AM, Kevin Wolf wrote: > Am 22.01.2014 um 04:30 hat Fam Zheng geschrieben: >> Currently there is no way to query BlockStats of the backing chain. Th= is >> adds "backing" and "file" fields into BlockStats to make it possible. >> >> The old optional field "parent", which has the information for "file",= >> is kept there for backward compatibility, as an alias for "file". >> However field name "file" is more consistent with "file" option name i= n >> the block device configuration interface. >> >> Signed-off-by: Fam Zheng >=20 > I don't think it's a good idea to duplicate a field just because we lik= e > the new name better. Eric? I concur - duplication for the sake of naming consistency doesn't add any measurable benefit; I'd rather just improve the docs for the existing name (libvirt will be forced to use the old name for back-compat reasons anyway, making the new name useless cruft that just makes the JSON longer and cost more cycles to parse then discard). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nbUXus2wtnHQ3kaFKEdC9JR4CjGhltoHh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS38LRAAoJEKeha0olJ0NqbacH/1cIRasmTtiwFGrmh82mvGkN pBRphCHhoFXX4CKoQ+u/i1kA5ILFkmiN3BjS0WUMShRbPypdMP1AGb7PmJ/xfGsH hqi6j/WnPUW1lrdGqc3KEVFDmx0liFp35KDiC/19ffYMAuEnssEtp7vxVGzfpN5S dlCXArbAeVbZYOSNSVg0pbvgi2fx5/RHn7b3HEDOznJ0Qe5BQ4nGcUfUYZzdsBIF e9st+9D1NbcV0V8lFqSq2kH6OpP2OZLzZfAD0R8rYI+5NuT2GJgCSzgpUs5xLL9V RvvBuJaQzs0H+xdYVM1fMw1EHhfY8Sf1hHJwdADbY5WALO+mNkHg7xLpfsq/9Jo= =r7UB -----END PGP SIGNATURE----- --nbUXus2wtnHQ3kaFKEdC9JR4CjGhltoHh--