From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6036-0003UN-J2 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 10:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6031-0002yN-Sk for qemu-devel@nongnu.org; Wed, 22 Jan 2014 10:49:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6031-0002y6-Kc for qemu-devel@nongnu.org; Wed, 22 Jan 2014 10:48:59 -0500 Message-ID: <52DFE85B.6090100@redhat.com> Date: Wed, 22 Jan 2014 16:48:43 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1389944779-31899-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1389944779-31899-2-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1389944779-31899-2-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/13 v7] dump: const-qualify the buf of WriteCoreDumpFunction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/17/14 08:46, qiaonuohan wrote: > WriteCoreDumpFunction is a function pointer that points to the function used to > write content in "buf" into core file, so "buf" should be const-qualify. > > Signed-off-by: Qiao Nuohan > --- > dump.c | 2 +- > include/qom/cpu.h | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dump.c b/dump.c > index 80a9116..42622de 100644 > --- a/dump.c > +++ b/dump.c > @@ -99,7 +99,7 @@ static void dump_error(DumpState *s, const char *reason) > dump_cleanup(s); > } > > -static int fd_write_vmcore(void *buf, size_t size, void *opaque) > +static int fd_write_vmcore(const void *buf, size_t size, void *opaque) > { > DumpState *s = opaque; > size_t written_size; > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index 7739e00..57b4164 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h > @@ -28,7 +28,8 @@ > #include "qemu/tls.h" > #include "qemu/typedefs.h" > > -typedef int (*WriteCoreDumpFunction)(void *buf, size_t size, void *opaque); > +typedef int (*WriteCoreDumpFunction)(const void *buf, size_t size, > + void *opaque); > > /** > * vaddr: > Reviewed-by: Laszlo Ersek