From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W60KB-0005mE-Sk for qemu-devel@nongnu.org; Wed, 22 Jan 2014 11:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W60K7-0000ud-93 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 11:06:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W60K7-0000uZ-0t for qemu-devel@nongnu.org; Wed, 22 Jan 2014 11:06:39 -0500 Message-ID: <52DFEC85.7030700@redhat.com> Date: Wed, 22 Jan 2014 17:06:29 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1389944779-31899-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1389944779-31899-5-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1389944779-31899-5-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/13 v7] dump: add API to write vmcore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/17/14 08:46, qiaonuohan wrote: > Function is used to write vmcore in flatten format. In flatten format, data is > written block by block, and in front of each block, a struct > MakedumpfileDataHeader is stored there to indicate the offset and size of the > data block. > > struct MakedumpfileDataHeader { > int64_t offset; > int64_t buf_size; > }; > > Signed-off-by: Qiao Nuohan > Reviewed-by: Laszlo Ersek > --- > dump.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) Compared with v6 03/11, this patch hardwires the flat format (and adapts the commit message too). My R-b stands. Laszlo