From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W60Mj-00083Z-F1 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 11:09:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W60Md-0001XI-MS for qemu-devel@nongnu.org; Wed, 22 Jan 2014 11:09:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W60Md-0001XC-E7 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 11:09:15 -0500 Message-ID: <52DFED1E.6000300@redhat.com> Date: Wed, 22 Jan 2014 17:09:02 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1389944779-31899-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1389944779-31899-6-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1389944779-31899-6-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/13 v7] dump: add API to write elf notes to buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/17/14 08:46, qiaonuohan wrote: > the function can be used by write_elf32_notes/write_elf64_notes to write notes > to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes > will write elf notes to vmcore directly. Instead, if buf_write_note is used, > elf notes will be written to opaque->note_buf at first. > > Signed-off-by: Qiao Nuohan > Reviewed-by: Laszlo Ersek > --- > dump.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) Thanks for addressing my tangential comments for v6 04/11. My R-b stands. Laszlo