From: Richard Henderson <rth@twiddle.net>
To: Xin Tong <trent.tong@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
aliguori@amazon.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB
Date: Wed, 22 Jan 2014 14:56:25 -0800 [thread overview]
Message-ID: <52E04C99.9050506@twiddle.net> (raw)
In-Reply-To: <CA+JLOiu55WGG11tK8HY4GYY73M38h7Dmhn9HM43mwqC62PKU9w@mail.gmail.com>
On 01/22/2014 02:40 PM, Xin Tong wrote:
> Thank you very much for your comments. I will provide fixes to the
> problems you raised and make sure my next patch passes the
> checkpatch.pl. I have a question I would like to make sure. After i go
> back and fixed the problems with this patch. I need to send another
> (different) email with the title of "[Qemu-devel] [PATCH v2] cpu:
> implementing victim TLB for QEMU system emulated TLB" and with the
> changes from both of the patches?
Well, "both" patches is a misnomer. One patch. The new patch.
The subject does not need to contain [Qemu-devel]. Try
git format-patch --subject-prefix='PATCH v2' master
from the branch containing your work. Then use "git send-email" to avoid the
line wrapping you had before.
But otherwise yes. And if you can get some different benchmarks, something
with more context switches than running a single program, that'd be great.
Peter mentioned an OS boot. I might suggest a complex shell script.
An example that comes to mind is qemu's own configure script. Set up a linux
virtual machine with everything to build qemu within the virtual machine. This
part can be done with -enable-kvm for speed. Then restart the vm without
-enable-kvm so that we use TCG. Then you can do something as simple as "time
./configure" to get your number.
r~
next prev parent reply other threads:[~2014-01-22 22:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 14:48 [Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB Xin Tong
2014-01-22 21:55 ` Richard Henderson
2014-01-22 22:40 ` Xin Tong
2014-01-22 22:56 ` Richard Henderson [this message]
2014-01-23 11:23 ` Alex Bennée
2014-01-23 13:50 ` Xin Tong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E04C99.9050506@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=qemu-devel@nongnu.org \
--cc=trent.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).