From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W66iv-0006DQ-Gw for qemu-devel@nongnu.org; Wed, 22 Jan 2014 17:56:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W66ik-00010H-NA for qemu-devel@nongnu.org; Wed, 22 Jan 2014 17:56:41 -0500 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:41332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W66ik-0000zq-GK for qemu-devel@nongnu.org; Wed, 22 Jan 2014 17:56:30 -0500 Received: by mail-qc0-f175.google.com with SMTP id x13so1501462qcv.34 for ; Wed, 22 Jan 2014 14:56:29 -0800 (PST) Sender: Richard Henderson Message-ID: <52E04C99.9050506@twiddle.net> Date: Wed, 22 Jan 2014 14:56:25 -0800 From: Richard Henderson MIME-Version: 1.0 References: <52E03E37.6040702@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xin Tong Cc: QEMU Developers , aliguori@amazon.com, afaerber@suse.de On 01/22/2014 02:40 PM, Xin Tong wrote: > Thank you very much for your comments. I will provide fixes to the > problems you raised and make sure my next patch passes the > checkpatch.pl. I have a question I would like to make sure. After i go > back and fixed the problems with this patch. I need to send another > (different) email with the title of "[Qemu-devel] [PATCH v2] cpu: > implementing victim TLB for QEMU system emulated TLB" and with the > changes from both of the patches? Well, "both" patches is a misnomer. One patch. The new patch. The subject does not need to contain [Qemu-devel]. Try git format-patch --subject-prefix='PATCH v2' master from the branch containing your work. Then use "git send-email" to avoid the line wrapping you had before. But otherwise yes. And if you can get some different benchmarks, something with more context switches than running a single program, that'd be great. Peter mentioned an OS boot. I might suggest a complex shell script. An example that comes to mind is qemu's own configure script. Set up a linux virtual machine with everything to build qemu within the virtual machine. This part can be done with -enable-kvm for speed. Then restart the vm without -enable-kvm so that we use TCG. Then you can do something as simple as "time ./configure" to get your number. r~