From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6MHI-0004Gz-FS for qemu-devel@nongnu.org; Thu, 23 Jan 2014 10:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6MHA-0001Cs-UZ for qemu-devel@nongnu.org; Thu, 23 Jan 2014 10:33:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6MHA-0001Cn-Na for qemu-devel@nongnu.org; Thu, 23 Jan 2014 10:33:04 -0500 Message-ID: <52E13626.7060505@redhat.com> Date: Thu, 23 Jan 2014 16:32:54 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1389944779-31899-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1389944779-31899-12-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1389944779-31899-12-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/13 v7] dump: add API to write dump pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, anderson@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, afaerber@suse.de On 01/17/14 08:46, qiaonuohan wrote: > functions are used to write page to vmcore. vmcore is written page by page. > page desc is used to store the information of a page, including a page's size, > offset, compression format, etc. > > Signed-off-by: Qiao Nuohan > --- > dump.c | 229 +++++++++++++++++++++++++++++++++++++++++++++++++ > include/sysemu/dump.h | 7 ++ > 2 files changed, 236 insertions(+), 0 deletions(-) You seem to have addressed everything I said for v6 09/11, except the QEMU_PACKED for PageDesc, but that's fine. (BTW I've just noticed that "PageDesc" is already used in "translate-all.c". No conflict here, but you might want to rename your struct, if you spin a v8 anyway.) All in all, great job! Reviewed-by: Laszlo Ersek