From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Nh6-0000WL-0p for qemu-devel@nongnu.org; Thu, 23 Jan 2014 12:04:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Nh0-0006XX-17 for qemu-devel@nongnu.org; Thu, 23 Jan 2014 12:03:55 -0500 Received: from mail-ie0-x22e.google.com ([2607:f8b0:4001:c03::22e]:39870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Ngz-0006XJ-Oa for qemu-devel@nongnu.org; Thu, 23 Jan 2014 12:03:49 -0500 Received: by mail-ie0-f174.google.com with SMTP id tp5so1418955ieb.5 for ; Thu, 23 Jan 2014 09:03:49 -0800 (PST) Sender: Richard Henderson Message-ID: <52E14B6F.6050402@twiddle.net> Date: Thu, 23 Jan 2014 09:03:43 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389128439-10067-1-git-send-email-rth@twiddle.net> <1389128439-10067-25-git-send-email-rth@twiddle.net> <20140123152414.GA18378@dhcp-200-207.str.redhat.com> In-Reply-To: <20140123152414.GA18378@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, aliguori@amazon.com On 01/23/2014 07:24 AM, Kevin Wolf wrote: >> > @@ -6508,12 +6498,11 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, >> > else >> > ot = dflag ? MO_32 : MO_16; >> > val = cpu_ldub_code(env, s->pc++); >> > - gen_op_movl_T0_im(val); >> > gen_check_io(s, ot, pc_start - s->cs_base, >> > SVM_IOIO_TYPE_MASK | svm_is_rep(prefixes)); > This removal is wrong. gen_check_io() uses cpu_T[0] internally in order > to check the I/O bitmap. Now I get a #GP even for legitimate cases. > > The following patch (which is essentially a partial revert) makes it > work for me again. Should I send it as a proper patch or would you > prefer to clean up gen_check_io()? I guess some more explicit passing of > the port number couldn't hurt there, but I'm not familiar with TCG and > who knows what I would break while doing this... Oops. How did that happen? Please just send this as a proper patch and we'll worry about cleanup of gen_check_io later. You can add my Reviewed-by: Richard Henderson when you send it. Via qemu-trivial? r~