From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NrP-00047g-NW for qemu-devel@nongnu.org; Thu, 23 Jan 2014 12:14:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6NrK-0001LE-A8 for qemu-devel@nongnu.org; Thu, 23 Jan 2014 12:14:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45114 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6NrK-0001Kw-4p for qemu-devel@nongnu.org; Thu, 23 Jan 2014 12:14:30 -0500 Message-ID: <52E14DF3.9070006@suse.de> Date: Thu, 23 Jan 2014 18:14:27 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1389360699-9183-1-git-send-email-armbru@redhat.com> <1389360699-9183-2-git-send-email-armbru@redhat.com> <87ppo0rm11.fsf@blackfin.pond.sub.org> <52D000DF.60600@suse.de> <52E12A16.1020705@suse.de> <52E13925.5000506@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Markus Armbruster Cc: Alexander Graf , QEMU Developers Am 23.01.2014 17:00, schrieb Peter Maydell: > On 23 January 2014 15:45, Andreas F=C3=A4rber wrote: >> I have also now sent out a patch covering Macs and e500. So the answer >> is, I will accept a patch that has a reasonably small blacklist. The >> time you're arguing about this on IRC and here you could've spent >> actually helping investigate and fixing this... Even if I queued it an= d >> sent a pull, it would take days or weeks to go in, so I really don't s= ee >> why I should rush this series into my tree. >=20 > That's cool. I was only arguing because I was under the mistaken > impression you didn't want to take this patch at all until > everything was fixed. Well, maybe "everything" is the misunderstanding here? The following 3 patches address all my requests, ... http://patchwork.ozlabs.org/patch/313620/ http://patchwork.ozlabs.org/patch/313642/ http://patchwork.ozlabs.org/patch/313659/ ... and the first two would've been really easy to contribute for anyone who cared about a proper white- or blacklist: introducing a new define and taking away devices as long as everything still passes make check. More cleanup would be possible (i8257) if we took away audio, too (sb16 etc.). ppc40x was more involved, but still less than an hour to figure out. Now waiting on Alex to review and send a pull or to ack for me to queue. Having had to write these fixes myself now, maybe one of you two can contribute the real QOM test of recursively walking properties via qom-list and qom-get? :) > I'm working on a patch which improves tests/Makefile so it > autogenerates the list of sysemu-supporting targets and > adds qom-test to the test list for all of them, so we don't > even have to update the makefile when we add new architectures. Appreciate it, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg