From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6gv6-0006U2-NT for qemu-devel@nongnu.org; Fri, 24 Jan 2014 08:35:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6gv1-0006vN-Dm for qemu-devel@nongnu.org; Fri, 24 Jan 2014 08:35:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6gv1-0006vD-64 for qemu-devel@nongnu.org; Fri, 24 Jan 2014 08:35:35 -0500 Message-ID: <52E26C98.1070206@redhat.com> Date: Fri, 24 Jan 2014 14:37:28 +0100 From: Max Reitz MIME-Version: 1.0 References: <1390509099-695-1-git-send-email-benoit.canet@irqsave.net> <1390509099-695-9-git-send-email-benoit.canet@irqsave.net> <20140124132619.GF3342@dhcp-200-207.str.redhat.com> In-Reply-To: <20140124132619.GF3342@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , =?windows-1252?Q?Beno=EEt_Canet?= Cc: famz@redhat.com, Benoit Canet , qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com On 24.01.2014 14:26, Kevin Wolf wrote: > Am 23.01.2014 um 21:31 hat Beno=EEt Canet geschrieben: >> Signed-off-by: Benoit Canet >> --- >> block.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > I'm not going to merge this one yet. It breaks qemu-iotests case 071, > which would have to be adapted. > > However, first of all I'd like to hear the opinions of at least Eric an= d > Max on what BlockRef should really refer to. I think node names make > most sense, but perhaps it's a bit inconvenient and the command line > should default to node-name =3D id when id is set, but node-name isn't? The QAPI schema is pretty clear about this: =93references the ID of an=20 existing block device.=94 However, if the ID cannot be found, I think we=20 should interpret it as a reference to the node name. Therefore, I'd first try bdrv_find() and if that returns NULL, try again=20 with bdrv_find_node(). Max