From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6hyx-0001Jy-Vb for qemu-devel@nongnu.org; Fri, 24 Jan 2014 09:43:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6hyq-0004jX-4a for qemu-devel@nongnu.org; Fri, 24 Jan 2014 09:43:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8453) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6hyp-0004jM-SH for qemu-devel@nongnu.org; Fri, 24 Jan 2014 09:43:36 -0500 Message-ID: <52E27BCD.70303@redhat.com> Date: Fri, 24 Jan 2014 15:42:21 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390515366-32236-1-git-send-email-wei.liu2@citrix.com> <52E2790C.20304@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony PERARD , "xen-devel@lists.xen.org" , Wei Liu , QEMU Developers , Stefano Stabellini Il 24/01/2014 15:35, Peter Maydell ha scritto: >> > (1) decide that the Xen ring buffers are little-endian even on big-endian >> > CPUs >> > >> > (2) communicate the endianness of the Xen ring buffers via Xenstore, just >> > like we do for sizeof(long), and let the guest use either endianness on any >> > architecture. > You still have to make a choice about what you think > TARGET_WORDS_BIGENDIAN should be, and it's still going > to be wrong half the time and horribly confusing. > I just think this is completely the wrong solution to > the problem. Theoretically the xenpv-softmmu machine shouldn't need any code that depends on TARGET_WORDS_BIGENDIAN. If we changed every #ifdef TARGET_WORDS_BIGENDIAN to if(), we could compile it with "#define TARGET_WORDS_BIGENDIAN abort()". Paolo