From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6mdA-0006lH-Qc for qemu-devel@nongnu.org; Fri, 24 Jan 2014 14:41:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6md2-0004uM-DP for qemu-devel@nongnu.org; Fri, 24 Jan 2014 14:41:32 -0500 Received: from mail-yk0-x22d.google.com ([2607:f8b0:4002:c07::22d]:47639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6md2-0004uI-8D for qemu-devel@nongnu.org; Fri, 24 Jan 2014 14:41:24 -0500 Received: by mail-yk0-f173.google.com with SMTP id 20so6085416yks.4 for ; Fri, 24 Jan 2014 11:41:23 -0800 (PST) Sender: paolo.bonzini@gmail.com Message-ID: <52E2C1C1.7020200@redhat.com> Date: Fri, 24 Jan 2014 20:40:49 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1390580276-15298-1-git-send-email-pbonzini@redhat.com> <1390580276-15298-2-git-send-email-pbonzini@redhat.com> <20140124190809.GC11980@amt.cnet> In-Reply-To: <20140124190809.GC11980@amt.cnet> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] KVM: fix coexistence of KVM and Hyper-V leaves List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, vrozenfe@redhat.com Il 24/01/2014 20:08, Marcelo Tosatti ha scritto: >> > kvm_arch_init_vcpu's initialization of the KVM leaves at 0x40000100 >> > is broken, because KVM_CPUID_FEATURES is left at 0x40000001. Move >> > it to 0x40000101 if Hyper-V is enabled. >> > >> > Signed-off-by: Paolo Bonzini > arch/x86/include/asm/kvm_para.h > > static inline unsigned int kvm_arch_para_features(void) > { > return cpuid_eax(KVM_CPUID_FEATURES); > } > > Shouldnt it be using kvm_cpuid_base ? > Yes. Paolo