From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50850)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W7DF3-0003Ss-HL
	for qemu-devel@nongnu.org; Sat, 25 Jan 2014 19:06:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W7DEx-0005fH-ID
	for qemu-devel@nongnu.org; Sat, 25 Jan 2014 19:06:25 -0500
Received: from cantor2.suse.de ([195.135.220.15]:55226 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W7DEx-0005fD-BK
	for qemu-devel@nongnu.org; Sat, 25 Jan 2014 19:06:19 -0500
Message-ID: <52E45174.20701@suse.de>
Date: Sun, 26 Jan 2014 01:06:12 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1389781375-11774-1-git-send-email-kwolf@redhat.com>
	<1389781375-11774-11-git-send-email-kwolf@redhat.com>
	<52D946E4.7030708@suse.de>
	<CAJBZ5ePpM+zeBpBPHQ5D=Ory3H2U28UtfFxxCjKbhCkw9hCJaA@mail.gmail.com>
In-Reply-To: <CAJBZ5ePpM+zeBpBPHQ5D=Ory3H2U28UtfFxxCjKbhCkw9hCJaA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 10/42] qtest: Fix the bug about disable vnc
 causes "make check" fail
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kewei Yu <keweihk@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, anthony@codemonkey.ws

Am 18.01.2014 12:54, schrieb Kewei Yu:
>=20
> 2014/1/17 Andreas F=C3=A4rber <afaerber@suse.de <mailto:afaerber@suse.d=
e>>
>=20
>     Am 15.01.2014 11:22, schrieb Kevin Wolf:
>     > From: Kewei Yu <keweihk@gmail.com <mailto:keweihk@gmail.com>>
>     >
>     > When we disable vnc from "./configure", QEMU can't use the vnc op=
tion.
>     > So qtest can't use the "vnc -none ", otherwise "make check" fails=
.
>     > If QEMU uses "-display none", "-vnc none" is excrescent, So we
>     just need to drop it.
>     >
>     > Signed-off-by: Kewei Yu <keweihk@gmail.com <mailto:keweihk@gmail.=
com>>
>     > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com
>     <mailto:pbonzini@redhat.com>>
>     > Signed-off-by: Kevin Wolf <kwolf@redhat.com <mailto:kwolf@redhat.=
com>>
>=20
>     If the pull does get respun, 'Fix "make check" failing for
>     --disable-vnc' would be better English. ;)
>=20
>  Yes, It is more accurate. So.... I should re-submit it?

Sorry for the late answer. Since it was already in the maintainer's
queue and just about the commit message, it's not necessary for you to
resubmit, my comment was addressed to Kevin. When a "PULL" has been
sent, only major reasons (like build breakages, missing/wrong Sob, etc.)
lead to a resubmission by the maintainer.

Apart from the grammar issues ("causes ... to fail" or "... failure",
"disabling ... causes"), please keep in mind that many commits fix bugs,
so it will be more useful to the reader of patch/commit to read
prominently what is changing (and why) to determine whether he/she is
affected. Hope that explains.

Regards,
Andreas

>=20
>=20
>     Andreas
>=20
>     --
>     SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germa=
ny
>     GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG=
 N=C3=BCrnberg
>=20
> Kewei

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg