From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7Efq-0007Fh-QC for qemu-devel@nongnu.org; Sat, 25 Jan 2014 20:38:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7Efp-0003IM-Pt for qemu-devel@nongnu.org; Sat, 25 Jan 2014 20:38:10 -0500 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:5506 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7Efp-0003Hm-Ln for qemu-devel@nongnu.org; Sat, 25 Jan 2014 20:38:09 -0500 Message-ID: <52E466EF.7040501@comstyle.com> Date: Sat, 25 Jan 2014 20:37:51 -0500 From: Brad Smith MIME-Version: 1.0 References: <20131211004908.GA19241@rox.home.comstyle.com> <20140102075535.GA3509@stefanha-thinkpad.redhat.com> In-Reply-To: <20140102075535.GA3509@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Anthony Liguori Cc: qemu-devel@nongnu.org On 02/01/14 2:55 AM, Stefan Hajnoczi wrote: > On Tue, Dec 10, 2013 at 07:49:08PM -0500, Brad Smith wrote: >> This resolves the build issue with building the ROMs on OpenBSD on x86 archs. >> As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the >> whole OS/packages and so forth. The ROMs need to have PIE disabled. This >> is my initial attempt at trying to get somehting upstream so that QEMU >> both builds out of the box and to resolve the build issue with the >> buildbots that has been around for awhile. We have a patch in our ports >> tree but it is just the flags hardcoded into the Makefile which obviously >> is not appropriate for upstream. >> >> From the OpenBSD buildbots.. >> Building optionrom/multiboot.img >> ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC >> >> Signed-off by: Brad Smith >> --- >> >> Change in v2: >> * Fix '==' is not portable syntax. >> >> Change in v3: >> * Rename variables and use compile_prog to detect the presence of the compiler/linker >> flags, as suggested by Stefan Weil. > > Reviewed-by: Stefan Hajnoczi Is there some sort of process I am missing to have build fixes commited so that QEMU actually builds? -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.