From: Tom Musta <tommusta@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: PowerPC <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/8] target-ppc: Add bctar Instruction
Date: Mon, 27 Jan 2014 13:34:47 -0600 [thread overview]
Message-ID: <52E6B4D7.9070405@gmail.com> (raw)
In-Reply-To: <F5966464-E2A2-40E6-927E-1BA8C1611224@suse.de>
On 1/27/2014 12:46 PM, Alexander Graf wrote:
>> static inline void gen_bcond(DisasContext *ctx, int type)
>> > {
>> > @@ -3756,10 +3757,12 @@ static inline void gen_bcond(DisasContext *ctx, int type)
>> > TCGv target;
>> >
>> > ctx->exception = POWERPC_EXCP_BRANCH;
>> > - if (type == BCOND_LR || type == BCOND_CTR) {
>> > + if (type == BCOND_LR || type == BCOND_CTR || type == BCOND_TAR) {
>> > target = tcg_temp_local_new();
>> > if (type == BCOND_CTR)
>> > tcg_gen_mov_tl(target, cpu_ctr);
>> > + else if (type == BCOND_TAR)
>> > + gen_load_spr(target, SPR_TAR);
> How frequently is this used in generated code? Would it make sense to make it a global TCG variable?
>
I have not yet seen a case of this being generated by the newer compilers. But it is certainly not difficult
or much more code to make it be a global.
next prev parent reply other threads:[~2014-01-27 19:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 17:54 [Qemu-devel] [PATCH 0/8] target-ppc: Base ISA V2.07 for Power8 Tom Musta
2014-01-27 17:54 ` [Qemu-devel] [PATCH 1/8] target-ppc: Add Flag for bctar Tom Musta
2014-01-27 17:54 ` [Qemu-devel] [PATCH 2/8] target-ppc: Add Target Address SPR (TAR) to Power8 Tom Musta
2014-01-27 17:54 ` [Qemu-devel] [PATCH 3/8] target-ppc: Add bctar Instruction Tom Musta
2014-01-27 18:46 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-01-27 19:34 ` Tom Musta [this message]
2014-01-27 21:44 ` Alexander Graf
2014-01-27 17:54 ` [Qemu-devel] [PATCH 4/8] target-ppc: Add Flag for ISA 2.07 Load/Store Quadword Instructions Tom Musta
2014-01-27 17:54 ` [Qemu-devel] [PATCH 5/8] target-ppc: Load Quadword Tom Musta
2014-01-27 18:55 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-01-27 19:53 ` Tom Musta
2014-01-27 21:43 ` Alexander Graf
2014-01-27 17:54 ` [Qemu-devel] [PATCH 6/8] target-ppc: Store Quadword Tom Musta
2014-01-27 17:54 ` [Qemu-devel] [PATCH 7/8] target-ppc: Add Load Quadword and Reserve Tom Musta
2014-01-27 18:59 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-01-27 20:01 ` Tom Musta
2014-01-27 17:54 ` [Qemu-devel] [PATCH 8/8] target-ppc: Add Store Quadword Conditional Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E6B4D7.9070405@gmail.com \
--to=tommusta@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).