From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7tV7-0007OQ-H6 for qemu-devel@nongnu.org; Mon, 27 Jan 2014 16:13:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W7tUz-0007Ct-LZ for qemu-devel@nongnu.org; Mon, 27 Jan 2014 16:13:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W7tUz-0007Cm-C5 for qemu-devel@nongnu.org; Mon, 27 Jan 2014 16:13:41 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0RLDeIS007007 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Jan 2014 16:13:40 -0500 Message-ID: <52E6CC03.1070304@redhat.com> Date: Mon, 27 Jan 2014 14:13:39 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qTkEONEFeXLFlxFDNVjujvIjog7AeVrWc" Subject: Re: [Qemu-devel] [PATCH 0/2] Remove unsupported / empty .bdrv_make_empty functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qTkEONEFeXLFlxFDNVjujvIjog7AeVrWc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/27/2014 02:09 PM, Jeff Cody wrote: > QED and QCOW2 both have .bdrv_make_empty stubs that do nothing. In the= =20 > case of QED, it returns an error (-ENOTSUP), which causes problems with= > bdrv_commit(). >=20 > This removes those stubs. >=20 > Jeff Cody (2): > block: remove QED .bdrv_make_empty implementation > block: remove qcow2 .bdrv_make_empty implementation >=20 > block/qcow2.c | 21 --------------------- > block/qed.c | 6 ------ > 2 files changed, 27 deletions(-) Always fun when you can fix bugs by pure deletion :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qTkEONEFeXLFlxFDNVjujvIjog7AeVrWc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS5swDAAoJEKeha0olJ0NqoT8IAJRfQR8q6PetIRf8Y4Ci3idz JLRGdScvT/HvYGtXsmVQpe9yfBGFG6O+nE/aVjuwo8LD8jIH2nd96k8uvhQnGaWj sH3TEZxl43vbX/9Uet3mLIOYjI/BohQZ79lNCk0Mlzv1F9aNWNZkiI3eeBegbVIt ykERWFJBqIzlA2mJjy43vYHy9ziWDevI0SfyVxHuPjbslTKppnp/wWxYeWSSxER3 Qa2zuPNa6ZMgKqxH0wYW0+gCGe56LSKK3rEKtWu7iVPPwEIy3+wPx5z5+wPTGDnh QNGhePkyncCELa6Bri30jVp+kZBKUwzF1KDcl+L4AYuPoQpWxoe2mF/mtZ6Qpxg= =PRqv -----END PGP SIGNATURE----- --qTkEONEFeXLFlxFDNVjujvIjog7AeVrWc--