From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44484)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W84y9-00027r-Ud
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 04:28:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W84y1-0005y1-P5
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 04:28:33 -0500
Received: from cantor2.suse.de ([195.135.220.15]:37401 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W84y1-0005xi-JO
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 04:28:25 -0500
Message-ID: <52E77834.8010004@suse.de>
Date: Tue, 28 Jan 2014 10:28:20 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1389776859.git.peter.crosthwaite@xilinx.com>	<b99b3e503d06ea167e34884460e000f6c187c27f.1389776859.git.peter.crosthwaite@xilinx.com>	<CAFEAcA8wwR_Hn=tgqgTetbDS0RSbYuLAW17MxoV=csxyHqwDZQ@mail.gmail.com>
	<CAEgOgz6WP7fomCZNOVWE1chhR38Mr_YAbs8vYZt=9b20DQxfRA@mail.gmail.com>
In-Reply-To: <CAEgOgz6WP7fomCZNOVWE1chhR38Mr_YAbs8vYZt=9b20DQxfRA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH target-arm v5 4/5] arm: Implement reset
	GPIO.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>

Hi,

Am 28.01.2014 01:48, schrieb Peter Crosthwaite:
> On Tue, Jan 28, 2014 at 3:52 AM, Peter Maydell <peter.maydell@linaro.or=
g> wrote:
>> Is there anything really ARM-specific in this reset_gpio
>> function, or could it be implemented at a common level for
>> all target architectures?
>>
>=20
> Not yet, but probably will be ARM specific once I add the cpu reset
> pin state. Unless Andreas is happy for that pin state and all this
> code to go up to the base TYPE_CPU class.
>=20
> I wonder however, whether different arch will have level/edge/high/low
> variances in reset behavior that must be accommodated.
>=20
> Andreas, you want this in CPU or should we leave it here in ARM land?

I'm currently swimming in work, so haven't really reviewed this yet...

If you have a good solution that requires additions to common CPU state
then so be it. However, keep in mind that for x86 at least we need to
remain migration-compatible, so state additions would need to go into an
optional VMState subsection for backwards compatibility.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg