From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48335)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W8AnH-0002zm-Qq
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 10:41:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W8AnB-00048j-RH
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 10:41:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61689)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W8AnB-00047Q-Iw
	for qemu-devel@nongnu.org; Tue, 28 Jan 2014 10:41:37 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0SFfYMF008726
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 28 Jan 2014 10:41:35 -0500
Message-ID: <52E7CFAB.6090801@redhat.com>
Date: Tue, 28 Jan 2014 16:41:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1390922439-30750-1-git-send-email-dgilbert@redhat.com>
In-Reply-To: <1390922439-30750-1-git-send-email-dgilbert@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] Name threads
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, qemu-devel@nongnu.org
Cc: lersek@redhat.com, mst@redhat.com

Il 28/01/2014 16:20, Dr. David Alan Gilbert (git) ha scritto:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This series uses pthread_setname_np (when available) to set the names on
> threads that QEMU creates to make life easier when debugging.
>
> It's turned off by default (because there were worries that it might break
> tools that relied on process names) but is enabled by adding
>
>    namethreads=on
>
> to the --name option.
>
> Note that the initial thread still has the default name (or the value passed
> as the process= parameter to --name).

I plead guilty to bikeshedding and propose s/namethreads/threads/.

Also, how did you test the merging of options?  Perhaps parse_name could 
itself call qemu_find_opts("name"), and could be called just once at the 
end of option parsing.  But that's just how *I* would have written the 
code, and what you have is fine if it works with multiple occurrences of 
-name.

Thanks for submitting this patch!

Paolo