From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8BPa-0002uL-5X for qemu-devel@nongnu.org; Tue, 28 Jan 2014 11:21:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8BPU-0008CH-5f for qemu-devel@nongnu.org; Tue, 28 Jan 2014 11:21:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8BPT-0008C7-Mt for qemu-devel@nongnu.org; Tue, 28 Jan 2014 11:21:12 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0SGL8Br013770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 Jan 2014 11:21:09 -0500 Message-ID: <52E7D8EF.7060000@redhat.com> Date: Tue, 28 Jan 2014 17:21:03 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1390922439-30750-1-git-send-email-dgilbert@redhat.com> <1390922439-30750-4-git-send-email-dgilbert@redhat.com> <20140128155633.GB19526@redhat.com> <20140128161244.GA31213@work-vm> In-Reply-To: <20140128161244.GA31213@work-vm> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] Add a 'name' parameter to qemu_thread_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, "Michael S. Tsirkin" On 01/28/14 17:12, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (mst@redhat.com) wrote: >> On Tue, Jan 28, 2014 at 03:20:39PM +0000, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> If enabled, set the thread name at creation (on GNU systems with >>> pthread_set_np) >>> Fix up all the callers with a thread name >>> >>> Signed-off-by: Dr. David Alan Gilbert >> >> Thanks for the patch. >> >> It worries me that tool might start assuming specific >> thread names - this effectively becomes part of >> management interface. >> >> We avoided this in the past except for VCPU threads - >> in particular we only expose thread id for VCPU threads. >> How about some generic name for non-VCPU threads >> to avoid this issue? > > Since I'm doing migration development, restriction to VCPU > threads doesn't help me much. I'm not doing migration development, but I agree that the feature is only really useful if *all* threads have names. (IOW when it completely saves the developer the work to figure out which thread is which.) > Putting big scary warnings somewhere (where?) to say that > the names aren't guaranteed is all I can think of. > (I did put that warning in the cover letter). > > I guess I could change the option name to debug-threads > to make it clear it's for debug. > >> Also - should we put VCPU # in the thread name? > > Yeh that's something I could add. Would be very useful. Thanks Laszlo